FIX: CI Windows Env Check#1346
Merged
Merged
Conversation
Signed-off-by: AidCheng <cn.aiden.cheng@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with CI environment checking on Windows platforms by correcting the output handling in the diff command.
- Replaces
diff_outputwithresults.join("")for non-Unix platforms in the diff command execution
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| #[cfg(not(unix))] | ||
| { | ||
| io::stdout().write_all(diff_output.as_bytes()).unwrap(); | ||
| io::stdout().write_all(results.join("").as_bytes()).unwrap(); |
There was a problem hiding this comment.
The variable 'results' is not defined in the visible context. This will cause a compilation error. Ensure that 'results' is properly defined and accessible in this scope, or verify that the correct variable name should be used here.
genedna
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.